fix: esm package traversal#312
Merged
zbirenbaum merged 1 commit intozbirenbaum:masterfrom Sep 10, 2024
Merged
Conversation
when attempting to load the copilot nodejs will attempt to traverse upwards to find a package.json to determin if it should run in ESM or CJS mode. if it finds one that contains `"type": "module"` it will crash copilot because ESM handles various things different and the copilot impl is CJS. the solution here is to place a package.json file to prevent node from traversing upwards.
Contributor
Author
|
also linking this issue from node for others trying to fix this in their apps. |
Contributor
Author
|
can any devs in the chat take a look when they get some free time? |
Owner
|
Thanks for researching this! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #306
I tested this by:
package.jsonin my home dir"type": "module"package.jsonsee in the diff to~/.local/share/nvim/lazy/copilot.lua/copilot/package.json