fix(panel): avoid being stuck "loading"#335
Merged
zbirenbaum merged 1 commit intozbirenbaum:masterfrom Dec 4, 2024
Merged
Conversation
Whenever the Copilot LSP knows it's not going to provide any suggestions, it replies with PanelSolutionsDone even before it completes the request. This resulted in us setting the status to "done" and then immediately resetting it to "loading", and thus getting stuck on "loading". The fix is to set the status to "loading" in the initial refresh call itself to avoid the race between on_solutions_done and the get_panel_completions callback.
Contributor
Author
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever the Copilot LSP knows it's not going to provide any suggestions, it replies with PanelSolutionsDone even before it completes the request. This resulted in us setting the status to "done" and then immediately resetting it to "loading", and thus getting stuck on "loading".
The fix is to set the status to "loading" in the initial refresh call itself to avoid the race between on_solutions_done and the get_panel_completions callback.