fix: wrong buffer encoding breaks accepting suggestions#336
Merged
zbirenbaum merged 1 commit intozbirenbaum:masterfrom Dec 4, 2024
Merged
fix: wrong buffer encoding breaks accepting suggestions#336zbirenbaum merged 1 commit intozbirenbaum:masterfrom
zbirenbaum merged 1 commit intozbirenbaum:masterfrom
Conversation
Contributor
imkerberos
added a commit
to imkerberos/copilot.lua
that referenced
this pull request
Dec 2, 2024
|
Also want this merged. It fixes the issue #344. |
Contributor
|
This merge needed for the all non-anscii files whose encoding is not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

These changes ensure that the text edits are applied using the correct encoding for the current buffer, improving compatibility with different file encodings.
The changes made in the
suggestion.luafile are as follows:Dynamic Encoding Retrieval:
vim.api.nvim_get_option_value('fileencoding', { buf = bufnr }).Buffer Number Handling:
bufnrvariable usingvim.api.nvim_get_current_buf().