fix: Using js server when on musl#414
Merged
AntoineGS merged 2 commits intozbirenbaum:betafrom Mar 28, 2025
Merged
Conversation
Collaborator
|
I will probably do an opt-in strategy for the binaries, so people can try it out and report back if it does not work but can easily switch back to the js version. Also, thanks for the PR! Sorry rough day :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I just saw you reverted the changes, but this pull request could be used as a base to make the integration with the official binaries. Maybe we can work a little on this one to create the
betabranch you were mentioning in #408Summary
Official binaries do not work on
muslsystems (ie. alpine or void). This PR detects the libc setting and fallbacks to the default js language-server.Maybe, we can add a configuration option to allow users to decide to use the
jsversion rather than the binary.NB: i left commented the download functions for a different PR