Skip to content

fix: Using js server when on musl#414

Merged
AntoineGS merged 2 commits intozbirenbaum:betafrom
alarmfox:fix-musl-systems
Mar 28, 2025
Merged

fix: Using js server when on musl#414
AntoineGS merged 2 commits intozbirenbaum:betafrom
alarmfox:fix-musl-systems

Conversation

@alarmfox
Copy link
Copy Markdown
Contributor

Hello,
I just saw you reverted the changes, but this pull request could be used as a base to make the integration with the official binaries. Maybe we can work a little on this one to create the beta branch you were mentioning in #408

Summary

Official binaries do not work on musl systems (ie. alpine or void). This PR detects the libc setting and fallbacks to the default js language-server.

Maybe, we can add a configuration option to allow users to decide to use the js version rather than the binary.

NB: i left commented the download functions for a different PR

@AntoineGS AntoineGS changed the base branch from master to beta March 27, 2025 23:53
@AntoineGS
Copy link
Copy Markdown
Collaborator

AntoineGS commented Mar 28, 2025

I will probably do an opt-in strategy for the binaries, so people can try it out and report back if it does not work but can easily switch back to the js version.
I will merge your changes to the new beta branch.
Feel free to do a checkout on it if you have anything else to add.

Also, thanks for the PR! Sorry rough day :)

@AntoineGS AntoineGS merged commit 3e7a5c2 into zbirenbaum:beta Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants