Add zcashd-compatible JSON-RPC endpoint
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
11-json-rpc
branch
3 times, most recently
from
53d19e2 to
c1cd082
Compare
str4d
force-pushed
the
11-json-rpc
branch
2 times, most recently
from
b6638eb to
5669a0d
Compare
daira
reviewed
Jan 24, 2025
daira
reviewed
Jan 24, 2025
zallet/src/components/json_rpc/methods/list_unified_receivers.rs
Outdated
Show resolved
Hide resolved
daira
reviewed
Jan 24, 2025
zallet/src/components/json_rpc/server/http_request_compatibility.rs
Outdated
Show resolved
Hide resolved
daira
reviewed
Jan 24, 2025
| /// - supplied `content-type` start with `text/plain`, for example: | ||
| /// - `text/plain` | ||
| /// - `text/plain;` | ||
| /// - `text/plain; charset=utf-8` |
There was a problem hiding this comment.
Should we instead match on "text/plain" [";" *]?
daira
reviewed
Jan 24, 2025
zallet/src/components/json_rpc/server/http_request_compatibility.rs
Outdated
Show resolved
Hide resolved
daira
reviewed
Jan 24, 2025
| /// In particular, the "application/x-www-form-urlencoded" header should be rejected, so browser forms can't be used to attack | ||
| /// a local RPC port. See "The Role of Routers in the CSRF Attack" in | ||
| /// <https://www.invicti.com/blog/web-security/importance-content-type-header-http-requests/> | ||
| /// - Checking all the headers is secure, but only because hyper has custom code that just reads the first content-type header. |
There was a problem hiding this comment.
I don't understand this comment.
There was a problem hiding this comment.
It comes from this review by teor: ZcashFoundation/zebra#6885 (review)
daira
reviewed
Jan 24, 2025
zallet/src/components/json_rpc/server/http_request_compatibility.rs
Outdated
Show resolved
Hide resolved
nuttycom
approved these changes
Jan 24, 2025
zallet/src/components/json_rpc/server/http_request_compatibility.rs
Outdated
Show resolved
Hide resolved
As `jsonrpsee` requires at least one RPC method, we mock out the `getwalletinfo` RPC method. Adapted from `zebra-rpc` and `zebrad` crates.
The code from `zebra-rpc` was only handling the `lightwalletd` client format which includes a `"jsonrpc": "1.0"` entry.
|
Force-pushed to address review comments. |
nuttycom
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonrpseelogic adapted fromzebra-rpcandzebradcrates.