Skip to content

Conversation

@str4d
Copy link
Collaborator

@str4d str4d commented May 1, 2025

No description provided.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I don't really understand the relationship between the magic constants and the arguments to the call methods; the magic constants seem to refer to a subset of the arguments; is what's happening simply that parameter documentation is only rendered when one of these constants is present?

@str4d
Copy link
Collaborator Author

str4d commented May 9, 2025

I don't really understand the relationship between the magic constants and the arguments to the call methods; the magic constants seem to refer to a subset of the arguments; is what's happening simply that parameter documentation is only rendered when one of these constants is present?

The arguments to the call methods include the internal state along with the method parameters. The trait to look at (which is what the buildscript is also "looking" at) is the methods::Rpc "trait" (it's actually a template from which jsonrpsee generates the RpcServer trait); the methods of this trait are what define the JSON-RPC method arguments.

@str4d str4d merged commit 37b9811 into main May 9, 2025
17 of 19 checks passed
@str4d str4d deleted the openrpc-params branch May 9, 2025 22:08
@str4d str4d added the A-rpc-interface Area: RPC interface label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc-interface Area: RPC interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants