Detect TDR errors corresponding to TransactionStatus::TxidNotRecognized
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed` This prevents Zallet from crashing when it encounters a coinbase transaction. It will however indefinitely re-request the null txid until we bring in zcash/librustzcash#1821.
str4d
added
the
I-error-handling
str4d
commented
Jun 12, 2025
| // - "No such mempool or main chain transaction" (zebrad) | ||
| Err(FetchServiceError::JsonRpcConnectorError( | ||
| JsonRpSeeConnectorError::JsonRpSeeClientError(e), | ||
| )) if e.contains("No such mempool") => TransactionStatus::TxidNotRecognized, |
There was a problem hiding this comment.
For reference, the Zaino error we get here is (example from being connected to zcashd -txindex):
FetchServiceError::JsonRpcConnectorError(
JsonRpSeeConnectorError::JsonRpSeeClientError(
"Error: Error status from node's rpc server: 500 Internal Server Error, {\"result\":null,\"error\":{\"code\":-5,\"message\":\"No such mempool or blockchain transaction. Use gettransaction for wallet transactions.\"},\"id\":327969}\n"
)
)There was a problem hiding this comment.
This is zingolabs/zaino#336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents Zallet from crashing when it encounters a coinbase transaction. It will however indefinitely re-request the null txid until we bring in zcash/librustzcash#1821.