Skip to content

Conversation

@str4d
Copy link
Collaborator

@str4d str4d commented Sep 11, 2025

RUSTFLAGS='--cfg=zallet_build="merchant_terminal"' cargo build

This:

  • is intended for IVK-only transaction detection, for merchant terminals.
  • has no keystore.
  • has no APIs for importing mnemonics, seeds, spending keys, or full viewing keys.
  • has no APIs for balance (IVKs cannot correctly maintain balance).
  • has no APIs for spending.
  • is only tested on Linux, and the tests are not required to pass (it will not block Zallet development).
  • is best-effort only.

@str4d str4d force-pushed the merchant-terminal-build branch from 4186637 to 00fbbbc Compare September 11, 2025 01:35
@str4d
Copy link
Collaborator Author

str4d commented Sep 11, 2025

Force-pushed to fix the config flag logic in the build script (which was enabling both merchant_terminal and wallet simultaneously, causing the merchant_terminal build to be identical to wallet).

mod get_new_account;
#[cfg(zallet_build = "wallet")]
mod get_notes_count;
#[cfg(zallet_build = "wallet")]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this could probably be made more ergonomic with the cfg-if crate.

@str4d str4d force-pushed the merchant-terminal-build branch from 00fbbbc to 676033d Compare September 11, 2025 01:46
`RUSTFLAGS='--cfg=zallet_build="merchant_terminal"' cargo build`
@str4d str4d force-pushed the merchant-terminal-build branch from 676033d to 5ae91d0 Compare September 11, 2025 02:00
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 676033d

I think I'd mildly prefer wallet to be a feature flag that is default-enabled; the machinery to automatically set the config flag seems a little janky to me. However, once we introduce IVK import, that RPC method would be visible in a "wallet" build given the additive nature of feature flags. Until we can adjust the zcash_client_sqlite implementation of APIs that return balance information to ensure that balance (which would almost certainly be incorrect) is never returned for IVK-only accounts, this approach is good.

@nuttycom nuttycom enabled auto-merge September 11, 2025 02:01
@str4d
Copy link
Collaborator Author

str4d commented Sep 11, 2025

Force-pushed to fix test failures.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 5ae91d0

@nuttycom nuttycom merged commit 328bb34 into main Sep 11, 2025
18 of 21 checks passed
@str4d str4d deleted the merchant-terminal-build branch September 11, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants