-
Notifications
You must be signed in to change notification settings - Fork 16
Download nightly build based on checksum #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download nightly build based on checksum #44
Conversation
|
Just FYI, ideally the |
Guess what I was looking into prior to merging your other PR 🙂 Very much agree here. We actually have this within Zed nowaways, but never exposed this to extensions. I'll ask the guy managing this stuff internally about it and then get back to you timely. Other than that, given the limitations, looks good. |
|
@MrSubidubi haha, very nice. Let me know once you have it and I'd be happy to update this PR or create a new one if we merge this in as a quickfix beforehand. |
|
@MrSubidubi do you think we could merge and release this workaround as a quickfix until we get the |
MrSubidubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides one comment. Happy to quickly get this out after once this is resolved.
MrSubidubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thank you for the fast follow-up! And thanks for your fix here!
This PR bumps the version of the Elixir extension to 0.2.4. Includes: - zed-extensions/elixir#38 - zed-extensions/elixir#44 - zed-extensions/elixir#45 - zed-extensions/elixir#48
Should close #42
Instead of downloading the nightly build to always the same folder
~/Library/Application\ Support/Zed/extensions/work/elixir/expert-nightlywhich doesn't overwrite the existing installation since the-nightlysuffix never changes, I use the checksum from theexpert_checksums.txtfile as a folder name - and therefore as a "version" which gets overwritten the next time a nightly release is pushed.I closed the previous PR #43 to move this to a feature branch