Skip to content

Conversation

@PJUllrich
Copy link
Contributor

Should close #42

Instead of downloading the nightly build to always the same folder ~/Library/Application\ Support/Zed/extensions/work/elixir/expert-nightly which doesn't overwrite the existing installation since the -nightly suffix never changes, I use the checksum from the expert_checksums.txt file as a folder name - and therefore as a "version" which gets overwritten the next time a nightly release is pushed.

I closed the previous PR #43 to move this to a feature branch

@cla-bot cla-bot bot added the cla-signed label Nov 12, 2025
@PJUllrich
Copy link
Contributor Author

Just FYI, ideally the zed_extension_api would return the digest as well in the GitHubReleaseAsset. Then we wouldn't need to fetch and parse the checksum TXT. But I'm too scared to touch the magic of the WASM stuff there :D

@MrSubidubi
Copy link
Contributor

Just FYI, ideally the zed_extension_api would return the digest as well in the GitHubReleaseAsset. Then we wouldn't need to fetch and parse the checksum TXT. But I'm too scared to touch the magic of the WASM stuff there :D

Guess what I was looking into prior to merging your other PR 🙂 Very much agree here.

We actually have this within Zed nowaways, but never exposed this to extensions. I'll ask the guy managing this stuff internally about it and then get back to you timely.

Other than that, given the limitations, looks good.

@MrSubidubi MrSubidubi self-assigned this Nov 12, 2025
@PJUllrich
Copy link
Contributor Author

@MrSubidubi haha, very nice. Let me know once you have it and I'd be happy to update this PR or create a new one if we merge this in as a quickfix beforehand.

@PJUllrich PJUllrich mentioned this pull request Nov 12, 2025
@PJUllrich
Copy link
Contributor Author

@MrSubidubi do you think we could merge and release this workaround as a quickfix until we get the GithubReleaseAsset.digest field? This extension is currently broken (unless manually fixed) at the moment.

Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides one comment. Happy to quickly get this out after once this is resolved.

Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thank you for the fast follow-up! And thanks for your fix here!

@MrSubidubi MrSubidubi merged commit 2f3fb25 into zed-extensions:main Nov 17, 2025
1 check passed
@MrSubidubi MrSubidubi mentioned this pull request Nov 17, 2025
MrSubidubi added a commit that referenced this pull request Nov 17, 2025
@MrSubidubi MrSubidubi mentioned this pull request Nov 17, 2025
MrSubidubi added a commit that referenced this pull request Nov 17, 2025
MrSubidubi added a commit to zed-industries/extensions that referenced this pull request Nov 17, 2025
@PJUllrich PJUllrich deleted the download-nightly-build-based-on-checksum branch November 17, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expert language server doesn't update to latest nightly builds

2 participants