Skip to content

Old dependencies do not get removed #133

@playdohface

Description

@playdohface

What happened?

When testing the changes from #132 I noticed that the extension consistently fails to delete the old versions of the dependencies (jdtls, lombok, debugger).
Reproduce like this:

  • find the extension work-dir, I am on MacOS so for me this is ~/Library/Application Support/Zed/extensions/work/java
  • run the extension with default configuration options
  • there should be folders debugger, jdtls, lombok there. Pick one of them and rename the file there to be another version, so e.g. cd debugger && mv com.microsoft.java.debug.plugin-0.53.2.jar com.microsoft.java.debug.plugin-0.52.2.jar
  • restart the language server

You should see the latest version being downloaded and the extension will work correctly, however the renamed file remains in the directory, as far as I can tell indefinitely.

What did you expect to happen?

After the new version has been downloaded successfully, the old version should be deleted.

Environment

Zed: 0.212.5
Platform: macOS Sequoia 15.7.1
Java Extension version: Latest main from this repo

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions