Formatter does not work

[vchicoro]

What happened?

If have the following configuration of the plugin on my settings.json file:

  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "jdt": {
              "ls": {
                "java": {
                  "home": "/path/to/java/home"
                }
              }
            },
            "format": {
              "onType": {
                "enabled": true
              },
              "settings": {
                "url": "/path/to/myFormatterFile.xml",
                "profile": "My Formatter Style"
              }
            },
            "saveActions": {
              "organizeImports": true
            }
          },
          "jdt": {
            "ls": {
              "lombokSupport": {
                "enabled": true
              }
            }
          },
          "saveActions": {
            "organizeImports": true
          }
        }
      }
    }
  }

As well as the following to disable prettier for java:

  "languages": {
    "Java": {
      "formatter": "language_server",
      "prettier": {
        "allowed": false
      }
    }
  }

However whenever y use the format buffer command (either from the context menu, using the hotkey or by saving the file with format on save option enabled) it does not work and (i'm assuming here) keeps applying the prettier formatter.

I've tested this config, with the same formatter file and profile in other LSP plugins for other editors and they work as expected (tested in VSCode, Sublime Text and emacs).

What did you expect to happen?

Whenever the formatter should apply it applies the formatter specified in config.

[valentinegb]

Can you test with 642da98 to see if that fixes anything?

[vchicoro]

I tested it using main branch on latest Zed Preview and still doesn't works 😢

[valentinegb]

Could you provide your formatter file so that I can test it?

[vchicoro]

Sure, here it is. As I said, it works on other editors using jdtls LSP so my guess is either a missconfiguration, Zed's own prettier or a bug on the plugin.

SushiFormatterStyle.xml.zip

[valentinegb]

I'm stumped on this to be honest, I'm not even sure if any initialization options I set are working now ;-;
I'm gonna need some help with this, sorry ^^'

[vchicoro]

No worries, I wish I could help but I don't know even a bit of Rust or the Zed editor itself. Keep on with the great job!

[Turtoise1]

Hey, i can add a few observations here :)

When i change the formatter to the language server formatter, the formatting is being changed. Zed seems to apply another formatter, not prettier anymore.

{
  "languages": {
    "Java": {
      "formatter": "language_server"
    }
  }
}

But when i want to change format settings of the language server like @vchicoro or like the following snippet, then they are not being applied to the language server formatter. That's even the case for a simple configuration like disabling the formatter:

{
  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "format": {
              "enabled": false
            }
          }
        }
      }
    }
  }
}

However, the problem is not that the jdtls language server options are not accepted at all; the lombok support for example works great.

{
  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "jdt": { "ls": { "lombokSupport": { "enabled": true } } },
          }
        }
      }
    }
  }
}

[valentinegb]

Hm, so initialization options are being seen by the language server... interesting, thank you for your observations!

That seems to suggest that JDTLS is at fault for the weirdness, but there apparently aren't any issues with the same language server in VSCode. I'll check later if maybe there's some launch option needed to enable formatting configuration, for some reason ¯\_(ツ)_/¯

[notpeter]

Totally untested, but I found reference elsewhere that you should only specify profile if your your XML contains multiple profiles (and SushiFormatterStyle.xml.zip only has one profile).

Can you try again with (removing the format.settings.profile key):

  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "format": {
              "settings": {
                "url": "/path/to/myFormatterFile.xml"
              }

Also is there anything under debug: open language server logs which gives a hint about what might be happening?

[Turtoise1]

Hm, so initialization options are being seen by the language server... interesting, thank you for your observations!

Sadly i found out that this is not the case right now XD

I did have some time to look inside the code base and saw that this specific setting:

{
  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "jdt": { "ls": { "lombokSupport": { "enabled": true } } },
          }
        }
      }
    }
  }
}

is being handled separately by this snippet from lib.rs:

        // Add lombok as javaagent if initialization_options.settings.java.jdt.ls.lombokSupport.enabled is true
        let lombok_enabled = LspSettings::for_worktree(language_server_id.as_ref(), worktree)?
            .initialization_options
            .and_then(|initialization_options| {
                initialization_options
                    .pointer("/settings/java/jdt/ls/lombokSupport/enabled")
                    .and_then(|enabled| enabled.as_bool())
            })
            .unwrap_or(false);
        if lombok_enabled {
            let lombok_jar_path = self.lombok_jar_path(language_server_id)?;
            let lombok_jar_full_path = std::env::current_dir()
                .map_err(|e| format!("could not get current dir: {e}"))?
                .join(&lombok_jar_path)
                .to_string_lossy()
                .to_string();
            args.push(format!("--jvm-arg=-javaagent:{lombok_jar_full_path}"));
        }

So now i think that we may need to handle the other initalization options like the formatter in some similar way. Maybe i find some time to look deeper into it :)