chore: version retrieval from tags #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playdohface
reviewed
Nov 3, 2025
Collaborator
playdohface
left a comment
playdohface
left a comment
There was a problem hiding this comment.
The only question that I have is: are we sure that the jdtls-assets will always be available the moment the github release is bumped? It's a reasonable assumption that they would, but idk how these releases are rolled out.
Collaborator
Author
|
Good point, we might want to have a fallback to the second release version available to cover instances where the release bump isn't reflected on the download website |
|
It might be cool for the user to be able to override the required version of jdtls in the settings. In case the latest isn't compatible for some reason or the tags don't exactly match the filenames or eclipse dumps jdk8 support or... |
- Extract into a function the retrival of the latest version from tags - Clean up retrieval of latest version of JDTLS
- Multiple versions are retrieved from tags - If first version fails downloading falls back to second one
tartarughina
force-pushed
the
version_retrieval
branch
from
2523cec to
ae01ab4
Compare
playdohface
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code maintainability by adopting a unified method to retrieve the latest version from git tags.