feat(gemset): store and re-use Worktree shell env #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Gemsetto store environment variables in the struct insteadof passing them to each method call. I think there was a change in upstream
how extensions commands inherit the process env. Without re-using Worktree
env the Ruby extension loses ability to use the correct Ruby version and other important variables like
PATHorRBENV_DIR.This also simplifies the API by:
envsfield to theGemsetstruct to store environment varsnew()to accept optional environment variablesenvsparameters from all public methodsexecute_gem_command