Skip to content

Conversation

@vitallium
Copy link
Collaborator

@vitallium vitallium commented Sep 11, 2025

Refactor Gemset to store environment variables in the struct instead
of passing them to each method call. I think there was a change in upstream
how extensions commands inherit the process env. Without re-using Worktree
env the Ruby extension loses ability to use the correct Ruby version and other important variables like PATH or RBENV_DIR.

This also simplifies the API by:

  • Adding envs field to the Gemset struct to store environment vars
  • Modifying new() to accept optional environment variables
  • Removing envs parameters from all public methods
  • Merging stored envs with command-specific envs in execute_gem_command
  • Updating all method calls and tests to use the new API pattern

Refactor Gemset to store environment variables in the struct instead
of passing them to each method call.
@vitallium vitallium force-pushed the vs/pass-shell-env-to-gemset branch from 940dd19 to c9b3bc7 Compare September 11, 2025 12:37
@vitallium vitallium merged commit 6416dda into main Sep 11, 2025
4 checks passed
@vitallium vitallium deleted the vs/pass-shell-env-to-gemset branch September 11, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants