-
Notifications
You must be signed in to change notification settings - Fork 22
Fix missing Tailwind completions #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitallium
reviewed
Apr 16, 2025
Collaborator
vitallium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@I-Info Hi, thanks for your contribution! I just have one question for you. Thanks!
|
@I-Info thanks a lot for trying to fix this 🙏🏻 |
Collaborator
|
@I-Info Thanks for fixing that and for pointing out the tricky issue with the overrides file! |
Closed
notpeter
pushed a commit
to zed-industries/extensions
that referenced
this pull request
Apr 30, 2025
Hi, this pull request updates the Ruby extension to v0.5.6, which includes many goodies and fixes. You can find the full list of changes on the release page [here](https://github.com/zed-extensions/ruby/releases/tag/v0.5.6). I'm also copying it below for your convenience: ## What's Changed ``` 1. Remove default tasks.json by @vitallium in zed-extensions/ruby#36 2. Remove else from outdent triggers by @vitallium in zed-extensions/ruby#42 3. Add completion_query_characters by @smitbarmase in zed-extensions/ruby#49 4. Add minimal README by @andyw8 in zed-extensions/ruby#54 5. Specify ? and ! as word characters by @andyw8 in zed-extensions/ruby#58 6. Add some basic tasks by @andyw8 in zed-extensions/ruby#57 7. Add constants to outline view by @vitallium in zed-extensions/ruby#60 8. Capture constants with assignments only for outline panel by @vitallium in zed-extensions/ruby#61 9. Include singleton class in outline by @joeldrapper in zed-extensions/ruby#67 10. Fix missing Tailwind completions by @I-Info in zed-extensions/ruby#62 11. Fix visibility keywords in outline by @joeldrapper in zed-extensions/ruby#65 12. Include method modifiers in outline by @joeldrapper in zed-extensions/ruby#66 13. Improve Ruby outlines with support for macros by @joeldrapper in zed-extensions/ruby#70 14. Mark instance & class variables as "@variable.special" by @asok in zed-extensions/ruby#63 15. Add task to evaluate selected text as Ruby by @andyw8 in zed-extensions/ruby#73 ``` Thanks!
lucascompython
pushed a commit
to lucascompython/extensions
that referenced
this pull request
Oct 3, 2025
Hi, this pull request updates the Ruby extension to v0.5.6, which includes many goodies and fixes. You can find the full list of changes on the release page [here](https://github.com/zed-extensions/ruby/releases/tag/v0.5.6). I'm also copying it below for your convenience: ## What's Changed ``` 1. Remove default tasks.json by @vitallium in zed-extensions/ruby#36 2. Remove else from outdent triggers by @vitallium in zed-extensions/ruby#42 3. Add completion_query_characters by @smitbarmase in zed-extensions/ruby#49 4. Add minimal README by @andyw8 in zed-extensions/ruby#54 5. Specify ? and ! as word characters by @andyw8 in zed-extensions/ruby#58 6. Add some basic tasks by @andyw8 in zed-extensions/ruby#57 7. Add constants to outline view by @vitallium in zed-extensions/ruby#60 8. Capture constants with assignments only for outline panel by @vitallium in zed-extensions/ruby#61 9. Include singleton class in outline by @joeldrapper in zed-extensions/ruby#67 10. Fix missing Tailwind completions by @I-Info in zed-extensions/ruby#62 11. Fix visibility keywords in outline by @joeldrapper in zed-extensions/ruby#65 12. Include method modifiers in outline by @joeldrapper in zed-extensions/ruby#66 13. Improve Ruby outlines with support for macros by @joeldrapper in zed-extensions/ruby#70 14. Mark instance & class variables as "@variable.special" by @asok in zed-extensions/ruby#63 15. Add task to evaluate selected text as Ruby by @andyw8 in zed-extensions/ruby#73 ``` Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tailwind auto completions is missing in Ruby / ERB. See: zed-industries/zed/issues/27118
After modifying the overrides:
In fact, these are just patches borrowed from the PR (zed-industries/zed/pull/28674) for Rust. I'm not familiar with Ruby, so I can't do more thorough testing.