I built a Codex ACP Adapter, but Diff review isn't working right.

[am-will]

Summary

Greetings, I have partially created a Codex ACP adapter, which is working in all areas (including slash commands) except one: the diffs arent working. Any and all changes show the entire file in green, and do not highlight the changes in the editor. It does wait for you to approve the changes before enacting them, but rejection doesn't work, and it still highlights the ENTIRE file in green instead of just the lines being modified.

I am wondering, is this a limitation of the Codex SDK in the way it handles diffs? It works fine for Gemini ACP and Claude ACP, and I tried to mimick their implementation, but nothing works. It's almost as though it deletes the original file, and creates an entirely new file: hence the green.

Any ideas? Thanks

Zed Version and System Specs

Zed: v0.207.3 (Zed)
OS: Linux X11 ubuntu 24.04
Memory: 31.2 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 3090 || NVIDIA || 580.65.06

[benbrandt]

Hi I am not sure what your implementation looks like, but we have been working on an adapter as well and had to make some changes to how codex handles the file reads/writes, so I am not surprised.

I'm not sure if you are providing codex with new tools or how you are handling it. Without looking at your adapter, I am not sure how you are mapping your file changes/diffs to ACP, but my guess is something isn't quite right there.

[am-will]

@benbrandt i was trying to handle diffs via the rust app server via mcp but its just not working sadly. I'll just await yours since you know what you're doing lol. I am kinda fumbling my way through. I was able to get slash commands and everything working except for diffs. Thanks :)