Skip to content

Comments

upgrading hterm-umdjs to 1.1.4#1745

Merged
chabou merged 1 commit intovercel:masterfrom
MartyGentillon:master
Apr 19, 2017
Merged

upgrading hterm-umdjs to 1.1.4#1745
chabou merged 1 commit intovercel:masterfrom
MartyGentillon:master

Conversation

@MartyGentillon
Copy link
Contributor

@MartyGentillon MartyGentillon commented Apr 15, 2017

Includes various hterm bug fixes including one where under certain
zooms and fonts the last line of console output does not display.

Updated hterm from version 15ed49071379e51ae47d929134366eb156a6943a
to a65fd913db6e931756d1199641aa45c556336dd4

see https://chromium.googlesource.com/apps/libapps/+log/HEAD/hterm
see https://chromium.googlesource.com/apps/libapps/+/6cec52ab8e442a4ec35c16907187f4e1a21a286f

@MartyGentillon
Copy link
Contributor Author

I have run this and can confirm that the last line of shell output appears to display correctly, even after prolonged output.

@chabou
Copy link
Contributor

chabou commented Apr 18, 2017

I think that this fix could be useful: https://chromium.googlesource.com/apps/libapps/+/ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6

To be precise, hterm-umdjs v1.1.4 updates hterm to a65fd913db6e931756d1199641aa45c556336dd4 (517c3ec8d8a52c3a166222b017ce16551be17134 is excluded)

Warning: some hterm next commits (but not included in this PR) could be harmful: https://chromium.googlesource.com/apps/libapps/+/70b94693f7c43e7a9a668479e5633f0d1770ac2e

@MartyGentillon
Copy link
Contributor Author

ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6 is a bug fix for a bug that was introduced earlier in the set of changes (7354202ec171287e200ec075c40e34784005fa97). Basically, it was introduced and then fixed between the two versions, and so shouldn't have any effect on hyper's behavior.

I suppose that I could update the commit message.

@chabou
Copy link
Contributor

chabou commented Apr 18, 2017

Oh, you're right for ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6 !

@MartyGentillon
Copy link
Contributor Author

Commit message updated to be correct.

Copy link
Contributor

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change a package version, yarn.lock file should be modified.
Can you add it? (Don't forget to rebase with master. yarn.lock has a lot of changes in last commit on master)

Includes various hterm bug fixes including one where under certain
zooms and fonts the last line of console output does not display.

Updated hterm from version 15ed49071379e51ae47d929134366eb156a6943a
to a65fd913db6e931756d1199641aa45c556336dd4

see https://chromium.googlesource.com/apps/libapps/+log/HEAD/hterm
see https://chromium.googlesource.com/apps/libapps/+/6cec52ab8e442a4ec35c16907187f4e1a21a286f
see dbkaplun/hterm-umdjs@b3ce695
@MartyGentillon
Copy link
Contributor Author

Done.

@chabou
Copy link
Contributor

chabou commented Apr 19, 2017

the only other commit is 65f33d65b66b06ba00ce5e92154695de5566ec17 but:

addBindings continues to work the way it did before

I tried this PR locally and everything seems ok

@chabou chabou merged commit 6e9a95b into vercel:master Apr 19, 2017
This was referenced Apr 19, 2017
@timothyis
Copy link
Contributor

timothyis commented Apr 20, 2017

Thanks @MartyGentillon ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants