Conversation
|
I have run this and can confirm that the last line of shell output appears to display correctly, even after prolonged output. |
|
I think that this fix could be useful: https://chromium.googlesource.com/apps/libapps/+/ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6 To be precise, Warning: some hterm next commits (but not included in this PR) could be harmful: https://chromium.googlesource.com/apps/libapps/+/70b94693f7c43e7a9a668479e5633f0d1770ac2e |
|
ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6 is a bug fix for a bug that was introduced earlier in the set of changes (7354202ec171287e200ec075c40e34784005fa97). Basically, it was introduced and then fixed between the two versions, and so shouldn't have any effect on hyper's behavior. I suppose that I could update the commit message. |
|
Oh, you're right for ccbc9ba0f0015da2b545dfb1751496eeeb92a5f6 ! |
|
Commit message updated to be correct. |
chabou
left a comment
There was a problem hiding this comment.
If you change a package version, yarn.lock file should be modified.
Can you add it? (Don't forget to rebase with master. yarn.lock has a lot of changes in last commit on master)
Includes various hterm bug fixes including one where under certain zooms and fonts the last line of console output does not display. Updated hterm from version 15ed49071379e51ae47d929134366eb156a6943a to a65fd913db6e931756d1199641aa45c556336dd4 see https://chromium.googlesource.com/apps/libapps/+log/HEAD/hterm see https://chromium.googlesource.com/apps/libapps/+/6cec52ab8e442a4ec35c16907187f4e1a21a286f see dbkaplun/hterm-umdjs@b3ce695
|
Done. |
|
the only other commit is 65f33d65b66b06ba00ce5e92154695de5566ec17 but:
I tried this PR locally and everything seems ok |
|
Thanks @MartyGentillon ❤️ |
Includes various hterm bug fixes including one where under certain
zooms and fonts the last line of console output does not display.
Updated hterm from version 15ed49071379e51ae47d929134366eb156a6943a
to a65fd913db6e931756d1199641aa45c556336dd4
see https://chromium.googlesource.com/apps/libapps/+log/HEAD/hterm
see https://chromium.googlesource.com/apps/libapps/+/6cec52ab8e442a4ec35c16907187f4e1a21a286f