Skip to content

Comments

re-implement clear, make it not buggy, fix CMD+K#1796

Merged
rauchg merged 1 commit intomasterfrom
fix/cmd+k
May 7, 2017
Merged

re-implement clear, make it not buggy, fix CMD+K#1796
rauchg merged 1 commit intomasterfrom
fix/cmd+k

Conversation

@rauchg
Copy link
Member

@rauchg rauchg commented May 7, 2017

This makes everything better

@rauchg rauchg requested a review from matheuss May 7, 2017 21:53
@ppot
Copy link
Contributor

ppot commented May 7, 2017

Haha 👍

Copy link
Contributor

@timothyis timothyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Best. Code. Yet."

Copy link
Member

@matheuss matheuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

@rauchg rauchg merged commit c491f7d into master May 7, 2017
@rauchg rauchg deleted the fix/cmd+k branch May 7, 2017 21:57
@albinekb
Copy link
Contributor

albinekb commented May 8, 2017

😂 awesome

@dcalhoun
Copy link
Contributor

@rauchg were there specific issues/bugs that this resolved? I'm curious as to what this changed. Thanks.

@dcalhoun
Copy link
Contributor

@rauchg to follow up on my previous comment, I ask specifically because I still see a lot of issues with clear in regards to using Jest. When using Jest's --watch mode, the runner always produces odd output (e.g. the history of previous runs is accessible if you scroll upwards).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants