[Hyper-cli] embed hpm by chabou · Pull Request #2375 · vercel/hyper

chabou · 2017-10-18T21:08:04Z

This PR has PR #2342 already merged into it.

Next steps:

Bonus:

Screencast:

* add_cli_cmd: Fix path for linux

* add_cli_cmd: Add Windows compatibility

chabou · 2017-11-04T16:03:55Z

One cool side effect is that Hyper CLI is our open <path> in new tab feature (on macOS):

But the more important thing is: THIS PR IS READY TO MERGE 🎉 🎉 🎉

peterfraedrich · 2017-11-09T17:31:33Z

I've submitted a PR for hpm that deprecates the use of npm-name and adds authenticated proxy support.
Link To PR

Stanzilla · 2017-11-19T23:04:07Z

I can't add reviewers but I nominate @albinekb :)

tkodev · 2017-11-26T08:06:10Z

Instead of going to the path in the first argument, can it be a command? hyper cd /path rather than just /path . This will allow cd to handle path existence (which it is designed to do), and also allow other applications to run things in hyper (such as an SFTP program opening a SSH connection in hyper)

Alternatively, use a flag argument. EX: `hyper --run "ls ~/". It might be out of scope with the current pull request though, but it's something to think about.

albinekb · 2017-11-27T12:34:39Z

+const args = require('args');
+const chalk = require('chalk');
+const opn = require('opn');
+// const columnify = require('columnify');


It will be used by lsRemote

albinekb · 2017-11-27T12:36:12Z

+    return true;
+  }
+  let msg = chalk.red(`Error! Config file not found: ${api.configPath}\n`);
+  msg += 'Please launch Hyper and retry.';


const message = ` ${chalk.red(`Error! Config file not found: ${api.configPath}`)} Please launch Hyper and retry. `

Should we add an issue to make the cli ask to create the file if it does not exists?

Yes.
Config creation should remain an Hyper task. And yes, we should improve this automatic creation. But this is not a blocker. Most of case, config file will be present.

albinekb · 2017-11-27T12:36:54Z

+        reject(err);
+        return;
+      }
+      // C:\Users\<user>\AppData\Local\hyper\app-2.0.4\resources\bin


// C:\Users\<user>\AppData\Local\hyper\app-<version>\resources\bin

I'll fix this

albinekb · 2017-11-27T12:37:37Z

@@ -0,0 +1,112 @@
+const fs = require('fs');
+const os = require('os');
+const npmName = () => Promise.resolve(); //require('npm-name');


I hoped that this PR would have been merged sooner: dominictarr/rc#94

albinekb · 2017-11-27T12:39:23Z

+  process.exit(1);
+});
+/*
+const lsRemote = () => {


It will be reactivated when NPM API request (URL and criteria) will be chosen.

chabou · 2017-11-27T14:01:01Z

@htkoca thank you for your feedback. You're right. Passing command could be very usefull.

Imo, I prefer command as an option like your --run suggestion. Most of time, users will only want to open Hyper on a (default) location. I don't want to oblige them to add cd to their path.

@albinekb @rauchg @leo Thoughts ?

chabou · 2018-01-09T14:58:40Z

For install, unsinstall, docs commands, hyper- prefix is added if not present.
For search and ls-remote commands, results are filtered to show only hyper- prefixed packages.

albinekb

Very nice work @chabou 🙏

vercel#2375 adds a wrapper CLI tool that parses the ~/.hyper.js configuration file. However, the static analysis logic can't possibly handle every possible configuration file without executing it. In my case, [my configuration file][0] defines a constant at the top, which means that the `module.exports` definition isn't the first statement. This breaks the parsing logic. However, this static analysis is only necessary if one wishes to use the CLI subcommands. They're not needed if one just wants to launch hyper. Unfortunately, the existing implementation tries to read from the AST immediately when `cli/api.js` is imported. This changes it to be lazy, and uses memoization retain the same reference, allowing the AST to still be mutated in-place. [0]: https://github.com/bgw/dotfiles/blob/665e83fd7a13be675ad0ae984478d5b0de502ee1/hyper.js#L4

amckinlay · 2018-04-26T20:30:03Z

 HYPER_PATH="$(dirname "$(dirname "$(dirname "$(realpath "$0")")")")"
 ELECTRON="$HYPER_PATH/$NAME.exe"
 if grep -q Microsoft /proc/version; then
+	echo "Warning! Due to WSL limitations, you can use CLI commands here. Please use Hyper CLI on cmd, PowerShell or GitBash/CygWin."


What does this mean? Do you mean "you cannot use Hyper CLI here"?

yeah just missing the 't

amckinlay · 2018-04-26T20:34:52Z

@chabou I left a comment about the language of the warning message in build/win/hyper.

As an aside, I wonder why my comment was on an outdated commit.

chabou · 2018-04-27T07:07:52Z

Yes this is a typo.
Can you send a PR or open an issue if you can't?
Thank you 🙏

chabou added 11 commits October 9, 2017 23:11

Symlink Hyper CLI on macOS

f41d7e8

Add cli building

4916285

Replace util.promisify by pify

3a38884

Remove util.promisify from app dep

a441d62

Use implicit return in promise chains

618a8cb

Explicit returns in promise chaining

1f670c8

Fix path for linux

5ac8dfd

Working cli on macOS

02df9d4

Merge branch 'add_cli_cmd' into embed_hpm

ba5687c

* add_cli_cmd: Fix path for linux

Delay config reloading to ensure file consistency

6147109

Disable lsr/search command and fix cli name in help

eea9631

chabou added the 👩‍🔬 Status: In Progress Issue or PR is currently active and work is in progress label Oct 18, 2017

chabou added this to the 2.0.0 milestone Oct 18, 2017

chabou added 7 commits October 19, 2017 01:48

Add Windows compatibility

1545d8e

Merge branch 'add_cli_cmd' into embed_hpm

1c2b6b0

* add_cli_cmd: Add Windows compatibility

Fix WSL laucnh script

3913d3a

Merge branch 'add_cli_cmd' into embed_hpm

f9a3346

Merge branch 'canary' into add_cli_cmd

be7e3d3

Add postinstall scripts for Linux

9baabe1

Merge branch 'add_cli_cmd' into embed_hpm

c06202c

chabou mentioned this pull request Nov 2, 2017

[Hyper-cli] Add cli cmd #2342

Closed

chabou added 9 commits November 3, 2017 00:29

Prevent launching multiple Hyper process on macOS

4309196

Fix Hyper path from cli.js on GitBash

87ccaa0

Add warning for WSL

180f169

Convert relative path arguments to absolute paths

e2943b9

Update yarn.lock

28eb7fe

Merge branch 'canary' into embed_hpm

321b509

Update yarn.lock

3225d4e

Wake up AppVeyor

82db3a7

Remove logs

e9bbb3e

Check if directory/file argument exists

6d15318

chabou removed the 👩‍🔬 Status: In Progress Issue or PR is currently active and work is in progress label Nov 4, 2017

Use commandPromise and wait for command termination

4822898

albinekb reviewed Nov 27, 2017

View reviewed changes

chabou mentioned this pull request Jan 4, 2018

Hyper CLI #2288

Closed

chabou added 5 commits January 9, 2018 14:47

Enable package checking on npm

fc45cb8

Fix comment

0fb085b

Add plugin list and search

3e5bc0d

Enforce hyper- prefix

2699d6e

Merge branch 'canary' into embed_hpm

77892cf

albinekb approved these changes Jan 9, 2018

View reviewed changes

chabou merged commit 5700690 into vercel:canary Jan 9, 2018

bgw mentioned this pull request Jan 12, 2018

Make CLI perform static analysis of config lazily #2593

Merged

amckinlay reviewed Apr 26, 2018

View reviewed changes

chabou deleted the embed_hpm branch April 27, 2018 07:06

Stanzilla mentioned this pull request Apr 27, 2018

fix a typo #2945

Merged

Stanzilla mentioned this pull request Jan 23, 2019

HyperCLI and WSL #3432

Open

Conversation

chabou commented Oct 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chabou commented Nov 4, 2017

Uh oh!

peterfraedrich commented Nov 9, 2017

Uh oh!

Stanzilla commented Nov 19, 2017

Uh oh!

tkodev commented Nov 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chabou commented Nov 27, 2017

Uh oh!

chabou commented Jan 9, 2018

Uh oh!

albinekb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amckinlay commented Apr 26, 2018

Uh oh!

chabou commented Apr 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chabou commented Oct 18, 2017 •

edited

Loading

tkodev commented Nov 26, 2017 •

edited

Loading