Switch from rAF to Promise to fix FOUC in Safari#63
Merged
Conversation
Closed
Contributor
|
This is awesome ! I didn't notice this solution, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the FOUC issue in Safari by switching from
requestAnimationFrame()toPromise#then()for the debouncing/batching mechanism.requestAnimationFrame()causes FOUC in Safari,setTimeout()causes FOUC in Chrome, whilePromise#then()ensures micro task enqueueing of styles update before paint in Safari, Chrome, and Firefox.This maintains the same semantics where only the latest call to
updateOnClient()causes the rendering of styles by "cancelling" the previously created promises by making them noops.Fixes #52
/cc @rauchg @nkzawa