Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Oct 16, 2018

  • BREAKING CHANGE?

Description

  • Update .c-btn to use text-overflow: ellipsis.
  • Update .c-dialog__footer__item display flex with min-width: 0.

Detail

Demo published for review https://garden.zendesk.com/css-components/modals/ (use Playground to test).

Before

screen shot 2018-09-19 at 13 09 34

After

screen shot 2018-10-15 at 5 05 23 pm

Checklist

  • 👌 style updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 component demo is up-to-date (yarn start)
  • ✅ all component states are represented
    (.is-hovered, .is-focused, etc.)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected sans Bedrock (?bedrock=false)
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

Copy link

@yara-simargil yara-simargil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you for the fix! 🎉

@jzempel jzempel merged commit 204e4f9 into master Oct 16, 2018
@jzempel jzempel deleted the jzempel/modal-footer branch October 16, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants