fix(breadcrumbs): chevron separator positioning #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jzempel merged 1 commit into master from jzempel/breadcrumb-chevron

Nov 29, 2018

Member

jzempel commented Nov 29, 2018

BREAKING CHANGE?

Description

Before

After

Detail

fix needed for zendeskgarden/react-components#215

Demo pre-published for review at https://garden.zendesk.com/css-components/breadcrumbs/.

Checklist

👌 style updates are Garden Designer approved (add the
designer as a reviewer)
🌐 component demo is up-to-date (yarn start)
✅ all component states are represented
(.is-hovered, .is-focused, etc.)
⬅️ renders as expected with reversed (RTL) direction
🤘 renders as expected sans Bedrock (?bedrock=false)
📝 tested in Chrome, Firefox, Safari, Edge, and IE11


          Tweak chevron positioning

0cc48bf

jzempel requested review from allisonacs and ginnywood

November 29, 2018 18:23

allisonacs approved these changes

View reviewed changes

jzempel merged commit ae2ccc0 into master

jzempel deleted the jzempel/breadcrumb-chevron branch

November 29, 2018 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet