Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Aug 22, 2018

  • BREAKING CHANGE?

Description

Fills-in the snapshot testing gaps for various Chrome component props.

Checklist

  • πŸ’… view component styling is based on a Garden CSS
    component
  • πŸ’‚β€β™‚οΈ includes new unit and snapshot tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build 526

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.201%

Totals Coverage Status
Change from base Build 524: 0.0%
Covered Lines: 1783
Relevant Lines: 1799

πŸ’› - Coveralls

Copy link
Contributor

@austingreendev austingreendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these in. With our new ignoreChanges option in lerna it looks like this won't trigger a new publish as well πŸŽ‰

@jzempel jzempel merged commit 376b4bb into master Aug 23, 2018
@jzempel jzempel deleted the jzempel/chrome-prop-testing branch August 23, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants