Skip to content

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Aug 23, 2018

Description

This is a continuation of the accessibility tweaks in #66. It includes:

  • Modals
    • Update markdown examples to include aria-label on <Close /> usages
  • Nofitications
    • Update markdown examples to include aria-label on <Close /> usages
  • Tables
    • Update markdown examples to include aria-label on <IconButton /> usages
  • Pagination
    • Originally I had a [role="navigation"] placed on the Pagination containing element. Turns out this is invalid and it should retain the listbox role applied by the SelectionContainer. This updates our default aria-label to be more descriptive.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage decreased (-0.001%) to 96.123% when pulling 738787b on agreen/documentation-accessability into 09cb171 on master.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Austin94 can we appease code cov on this one?

@austingreendev
Copy link
Contributor Author

@jzempel I think this is just complaining because I removed a line, which is lowering the overall project coverage.

The react-pagination package is currently at 100% coverage 👊

screen shot 2018-08-23 at 1 20 02 pm

Is there a setting to only look at changed files? Also, jest coverage has us at 99% while coveralls is at 96%. Not sure where the missmatch is coming from.

@austingreendev
Copy link
Contributor Author

@ryanseddon going to merge since you already approved in #66 🙇

@austingreendev austingreendev merged commit ba4bcb5 into master Aug 23, 2018
@austingreendev austingreendev deleted the agreen/documentation-accessability branch August 23, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants