fix(menus): Change handleOutsideMouseDown to handle when clicking on iframes #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanseddon
changed the title
sunesimonsen
approved these changes
Sep 10, 2018
Contributor
sunesimonsen
left a comment
sunesimonsen
left a comment
There was a problem hiding this comment.
👍 Thanks this seems to work very well.
Let's leave the menus inside other floating panels for another time.
| const doc = getDocument ? getDocument(this.props) : document; | ||
| const iframes = doc.querySelectorAll('iframe'); | ||
|
|
||
| return [...iframes].reduce( |
Contributor
There was a problem hiding this comment.
This should be good, but lets check that this is transpiled into IE11 compatible syntax.
Contributor
Author
There was a problem hiding this comment.
Yeah babel handles this fine transforms it to:
return [].concat(_toConsumableArray(iframes)Tested this already in all browsers in the checkbox marked in the description. So IE11 and edge are all good.
austingreendev
approved these changes
Sep 10, 2018
Contributor
There was a problem hiding this comment.
Very clean. Thanks @sunesimonsen for the guidance on this one!
[pending IE11 checks]
Contributor
🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #137
Description
Take two, as @sunesimonsen suggested, we had a pretty good solution in our previous menu component to handle closing the menu when clicked outside of the containers.
Detail
This adds a mousedown event to any same origin iframe documents and triggers the toggle function to see if it should close or not.
Checklist