Skip to content

fix(autocomplete): update multiselect example to not remove invalid tags #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2018
Merged

fix(autocomplete): update multiselect example to not remove invalid tags #153

merged 1 commit into from
Sep 14, 2018

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Sep 14, 2018

Description

The MultiSelect example within the react-autocomplete package had some weird behavior:

  • Regardless of which tag was selected, the last one was always deleted
  • No mouse interaction could select a menu item

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

coveralls commented Sep 14, 2018

Coverage Status

Coverage remained the same at 95.966% when pulling 32626ad on agreen/multiselect-example into ddfe2dc on master.

@austingreendev austingreendev merged commit 0dcbf0c into master Sep 14, 2018
@austingreendev austingreendev deleted the agreen/multiselect-example branch September 14, 2018 21:05
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

@ryanseddon ryanseddon Awaiting requested review from ryanseddon

@zillding zillding Awaiting requested review from zillding

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austingreendev @coveralls @jzempel