feat(testing): add renderWithTheme #171
Conversation
| */ | ||
|
|
||
| export { default as mountWithTheme } from './utils/mountWithTheme.js'; | ||
| export { default as renderWithTheme } from './utils/renderWithTheme.js'; |
There was a problem hiding this comment.
Is this any different to the above mountWithTheme?
There was a problem hiding this comment.
I'm a little lost as well. The only difference I can see is that mountWithTheme is passing the childContext types through the context with { context, childContextTypes: StyledThemeProvider.childContextTypes },
Without that you are probably seeing some Styled-Components console.warns in the console?
There was a problem hiding this comment.
@ryanseddon the only difference from the mountWithTheme is that it calls render instead of mount for the passed component. And this is the main purpose of this helper.
@Austin94 good catch! Added childContextTypes to the options.
There was a problem hiding this comment.
What use-case would this have for testing? The react-testing packages are mostly around utilities for enzyme & jest testing.
There was a problem hiding this comment.
This is exactly for snapshots testing with enzyme. Useful when a component composites smaller none exportable components and mounting to DOM is not needed. shallow doesn't render subcomponents and render is doing this down to html elements.
There was a problem hiding this comment.
Thanks for the clarification @ssidorchik. Is this change intended to clean up some of our tests or are you depending on this in your own codebase for testing?
There was a problem hiding this comment.
Already using the enzyme's render on a separate project. And would like to add the theme support.
austingreendev
left a comment
austingreendev
left a comment
There was a problem hiding this comment.
From our offline talk, LGTM! TIL about static markup rendering
Description
This pr adds
renderWithThemetesting helper.Detail
Checklist
designer as a reviewer)
component
yarn start)src/index.jsexport