feat(docs): update example SVG usages #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingreendev
force-pushed
the
agreen/update-svg-icons
branch
from
7141868 to
60733c1
Compare
jzempel
requested changes
Oct 10, 2018
| const HelpIcon = require('svg-react-loader?name=Settings!@zendeskgarden/svg-icons/src/14/support.svg'); | ||
| const MenuTrayIcon = require('svg-react-loader?name=Settings!@zendeskgarden/svg-icons/src/14/menu-tray.svg'); | ||
| const PersonIcon = require('svg-react-loader?name=Settings!@zendeskgarden/svg-icons/src/14/person.svg'); | ||
| const HelpIcon = require('svg-react-loader?name=Help!@zendeskgarden/svg-icons/src/16/lifesaver-stroke.svg'); |
Member
There was a problem hiding this comment.
A number of these modifications are premature as the component CSS styling hasn't yet been updated to properly accommodate 16px icons. As a result, the icons appear under-sized/weighted. We should probably schedule this PR to happen after the CSS updates.
Contributor
Author
There was a problem hiding this comment.
@allisonacs and I came to the same conclusion yesterday as well (forgot to post an update).
Lets hold off on this until the CSS/React component side has been updated.
Member
|
closed while we flow icon updates through design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all of the legacy (14px) svg-icon usages in our markdown examples.
@allisonacs, lets run through this together locally to make sure they are visually equivalent.
Checklist
designer as a reviewer)
component
yarn start)src/index.jsexport