fix(modals): update styling for sticky header/footer elements #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jzempel merged 1 commit into master from jzempel/modals-update

Oct 19, 2018

Member

jzempel commented Oct 19, 2018

BREAKING CHANGE?

Description

Update to @zendeskgarden/css-modals@6.3.4

Checklist

👌 design updates are Garden Designer approved (add the
designer as a reviewer)
💅 view component styling is based on a Garden CSS
component
🌐 Styleguidist demo is up-to-date (yarn start)
⬅️ renders as expected with reversed (RTL) direction
💂‍♂️ includes new unit and snapshot tests
📒 any new files are included in the packages src/index.js export
📝 tested in Chrome, Firefox, Safari, Edge, and IE11


          Update css-modals with fixes for sticky header/footer

d224888

jzempel requested review from austingreendev and ryanseddon

October 19, 2018 00:27

coveralls commented Oct 19, 2018

Coverage remained the same at 94.781% when pulling d224888 on jzempel/modals-update into 22e29e8 on master.

ryanseddon approved these changes

View reviewed changes

jzempel merged commit 6c00b49 into master

jzempel deleted the jzempel/modals-update branch

October 19, 2018 01:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet