fix(menus): Support top & left animations #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
austingreendev
left a comment
austingreendev
left a comment
There was a problem hiding this comment.
LGTM. Going to wait to 👍 until zendeskgarden/css-components#158 lands
ryanseddon
changed the title
jzempel
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for top & left animations in menus.
Detail
Pre published: https://garden.zendesk.com/react-components/menus/
Merged!
Once zendeskgarden/css-components#158 is merged this PR can come out of WIP.This PR is just deleting stuff as we don't need to conditionally check for top/left anymore.
Once this PR is merged I can bump Select too to support the same animations.
Checklist
designer as a reviewer)