fix(autocomplete|select): limit propTypes of maxHeight to string #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
Description
This PR corrects two
PropType's that were incorrectly listed as allowing bothstring & numbermaxHeightvalues.When we originally inlined these values with
stylethese prop-types made sense, but with the move of these values into a styled-components context it is no longer possible, unless we use the object syntax which is available in v4.Checklist
designer as a reviewer)
component
yarn start)