Skip to content

Conversation

@austingreendev
Copy link
Contributor

Closes #247

Description

This PR corrects two PropType's that were incorrectly listed as allowing both string & number maxHeight values.

When we originally inlined these values with style these prop-types made sense, but with the move of these values into a styled-components context it is no longer possible, unless we use the object syntax which is available in v4.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested review from gguine, jzempel, ryanseddon, sunesimonsen and vaevictis and removed request for gguine January 10, 2019 17:40
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.153% when pulling 7e0aecf on agreen/max-height-props into cbd748e on master.

@austingreendev austingreendev merged commit 32783bf into master Jan 10, 2019
@austingreendev austingreendev deleted the agreen/max-height-props branch January 10, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants