chore: initialise repo #1
Conversation
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
I think this initial setup kind of needs to be gone through with a fine-tooth comb and further updated with content that is contextually relevant for react-containers (i.e. no CSS, Views, Elements, etc.)
ryanseddon
force-pushed
the
ryan/initial_setup
branch
from
6707adf to
e3750ab
Compare
| "jest": true, | ||
| "BASE_PATH_NAME": true, | ||
| "PACKAGE_VERSION": true, | ||
| "COMPONENT_IDS": true |
There was a problem hiding this comment.
May not need this as containers don't expose component IDs.
There was a problem hiding this comment.
@Austin94 plz weigh-in here, based on recent conversation.
There was a problem hiding this comment.
@jzempel and I were discussing metrics this morning and came up with an interesting idea.
Would it be helpful to have a new data attribute specifically for the containers? i.e. data-garden-container-id and data-garden-version
This could help us identify areas where consumers have "ejected" into a container and help us identify new patterns.
There was a problem hiding this comment.
yep I think that makes sense
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
Left a comment you may intend to resolve in future PRs on this repo.
Adds initial files for containers repo
Borrows heavily from react-components.