This repository was archived by the owner on Jan 1, 2020. It is now read-only.
Added additional instanceof checks for Error types #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zend-mvc 3.0 will catch any Throwable when under PHP 7, we need to test for either `Exception` or `Error` in the error handling view scripts.
| <?php if (isset($this->display_exceptions) && $this->display_exceptions): ?> | ||
|
|
||
| <?php if(isset($this->exception) && $this->exception instanceof Exception): ?> | ||
| <?php if(isset($this->exception) && ($this->exception instanceof Exception || $this->exception instanceof Error)): ?> |
Member
Author
There was a problem hiding this comment.
Just a note: we cannot typehint against just Throwable, as the skeleton also supports PHP 5.6. As such, testing for either Exception or Error will satisfy any Throwable type from PHP 7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since zend-mvc 3.0 will catch any Throwable when under PHP 7, we need to test for either
ExceptionorErrorin the error handling view scripts.See zendframework/zend-mvc#157 (comment) for an example of why this is needed.