This repository was archived by the owner on May 1, 2019. It is now read-only.
Feature/add scrutinizer #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeeH
force-pushed
the
feature/add-Scrutinizer
branch
from
214d14e to
88e5ef2
Compare
There was a problem hiding this comment.
We don't have docs or examples directories, do we?
There was a problem hiding this comment.
no, it's a standard config I use across projects and does no harm
|
Something's still wrong with the Scrutinizer setup, can you have a look? |
There was a problem hiding this comment.
I guess we should not run php-cs-fixer on Travis, then?
There was a problem hiding this comment.
Scrutinizer is not going to fail - we want a failure on CS issues
There was a problem hiding this comment.
|
This proposal should be raised to crteam ML |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.