This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Disconnect persistent IbmDb2 connection #335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Aug 10, 2018
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
Closing as invalid as described in review comments: the original patch was correct, although unfinished.
| * | ||
| * @return ConnectionInterface | ||
| */ | ||
| public function disconnectPersistent() |
Member
There was a problem hiding this comment.
Providing a completely different API for something that is an implementation detail is incorrect, and breaks LSP (expanding the interface for an adapter means that it is no longer an adapter)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent database connections created with db2_pconnect don't close with the current disconnect method. This change adds a callable method for closing persistent database connections by using db2_pclose().