This repository was archived by the owner on Jan 29, 2020. It is now read-only.
moveTo: check targetDirectory and more #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pine3ree
commented
May 31, 2016
pine3ree
commented
- test for already moved file 1st (or 2nd) : testing a boolean can avoid heavier tests
- unify string and empty string in a single test: the exception message suggests both requirements
- test for already moved file 1st (or 2nd) : testing a boolean can avoid heavier tests - unify string and empty string in a single test: the exception message suggests both requirements
weierophinney
added a commit
that referenced
this pull request
Sep 7, 2016
moveTo: check targetDirectory and more
weierophinney
added a commit
that referenced
this pull request
Sep 7, 2016
Member
|
Thanks, @pine3ree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.