Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

@p2sk
Copy link

@p2sk p2sk commented Jun 15, 2018

To work with the Auth Grant Type the columns user_id and client_id have to be varchar in the oauth_auth_codes table.
See http://oauth2.thephpleague.com/auth-code-repository-interface/

To work with the Auth Grant Type the columns user_id and client_id have to be varchar in the oauth_auth_codes table. 
See http://oauth2.thephpleague.com/auth-code-repository-interface/
@belgattitude
Copy link

@p2sk

Need more thinking...

  1. The current sql script does not set/enforce foreign keys. I would start with that...

  2. if you change user_id/client_id you must do it for all tables, it's not the case. (the fk thing would have helped)...

  3. Not sure for client_id, but generally I would not set user_id as varchar... I guess most of user tables have their primary key defined as int/bigint...

  4. following your link http://oauth2.thephpleague.com/auth-code-repository-interface/, I cannot find anything requiring varchars for user_id, client_id, i.e :

getUserIdentifier() : string|null the user identifier represented by the auth code.

Return type string does not automatically means varchar... Probably a string numberic value (typically to prevent overflow on 32bits).

Hope it helps

@ezimuel
Copy link
Contributor

ezimuel commented Jul 11, 2018

@p2sk I agree with @belgattitude, we don't need to change user_id and client_id to be VARCHAR.

@ezimuel ezimuel closed this Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants