This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix broken build #173
Closed
Fix broken build #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Setting this options should be fix the problem with circular dependencies https://github.com/zendframework/zend-dom/blob/master/composer.json#L18-L19 However I think the best is don't require that componets. |
Ocramius
added a commit
that referenced
this pull request
Oct 25, 2015
Member
|
Handled in #177 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in 1a979e6 broke the build.
The router dependencies were previously pinned to
^0.1, which was installing the0.1.0versions of the variouszendframework/zend-expressive-*routerpackages, which in turn were dependent on^0.4ofzendframework/zend-expressive.Now they are pinned to version
~1.0-devof the router packages, i.e.dev-master, which depend on^1.0@rc"ofzendframework/zend-expressive. Since the root version is set to 0.4.1 viaCOMPOSER_ROOT_VERSION=0.4.1install fails, even though there is otherwise no issue with the composer dependencies.Using
COMPOSER_ROOT_VERSION=dev-masterallows the install to complete and should fix the build.Note:
COMPOSER_ROOT_VERSION=1.0.0would also work, as would removing the entireCOMPOSER_ROOT_VERSION=____setting, if you wish.