This repository was archived by the owner on Jan 30, 2020. It is now read-only.
RenameUploadTest: better test names #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
commented
Dec 17, 2018
| * @return void | ||
| */ | ||
| public function testCachesResultsOfFilteringSAPIUploads() | ||
| public function testFilterDoesNotAlterUnkownFileDataAndCachesResultsOfFilteringSAPIUploads() |
Contributor
Author
There was a problem hiding this comment.
The fact that we are testing the cache is important but not the main one. It's important to not alter the other data.
malukenho
approved these changes
Dec 20, 2018
Member
|
Thanks, @Slamdunk! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement for #79, I pushed the better names 1 second after merge ^^