Clarify boolean filter documentation #83
Conversation
marcguyer
commented
Jan 24, 2019
marcguyer
commented
- Is this related to documentation?
froschdesign
left a comment
froschdesign
left a comment
There was a problem hiding this comment.
The update is great! 👍
Only one change is necessary: revert the changes on spelling.
docs/book/standard-filters.md
Outdated
| ### Localized Booleans | ||
|
|
||
| As mentioned previously, `Zend\Filter\Boolean` can also recognise localized "yes" and "no" strings. | ||
| As mentioned previously, `Zend\Filter\Boolean` can also recognize localized "yes" and "no" strings. |
There was a problem hiding this comment.
Is there a reason why the spelling was changed here? So far we have no definition for a standard dialect in the documentation.
There was a problem hiding this comment.
I gave it some thought and research when making the change. I decided to change it for 2 reasons: There doesn't seem to be any other indication that it is written in a specific dialect -- e.g., no other usage of ise vs ize. So the first reason is for consistency. The 2nd reason is because I ran across this while researching it. I figured the ize variant was "better" globally. I'm no expert in linguistics but, there you go.
There was a problem hiding this comment.
@marcguyer
Thank you for your detailed answer. In the past I have done the same research several times.
The conclusion is we have no definition for a standard dialect. Therefore, I see no need to change anything in this direction and we should do this kind of discussion in the documentation issue tracker.
Thanks again for your effort!
|
@marcguyer |
2 participants
