Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@necromant2005
Copy link

Original implementation of Zend\Stdlib\PriorityQueue::insert applies only 2 arguments

    /**
     * Insert an item into the queue
     *
     * Priority defaults to 1 (low priority) if none provided.
     *
     * @param  mixed $data
     * @param  int $priority
     * @return PriorityQueue
     */
    public function insert($data, $priority = 1)

Original implementation of Zend\Stdlib\PriorityQueue::insert  applies only 2 arguments
    /**
     * Insert an item into the queue
     *
     * Priority defaults to 1 (low priority) if none provided.
     *
     * @param  mixed $data
     * @param  int $priority
     * @return PriorityQueue
     */
    public function insert($data, $priority = 1)
@Maks3w
Copy link
Member

Maks3w commented Jun 8, 2015

@necromant2005 Please add a unit test and review your PR because does not have sense. There is no uses of PriorityQueue in the modified file

@necromant2005
Copy link
Author

That's my fault. The external code was incorrectly used PriorityQueue in Form that led to issue.
I'm closing issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants