This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Add isGone method to \Zend\Http\Response #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the discussion in zendframework/zendframework#7368 this change adds a new method \Zend\Http\Response->isGone() to determine if the status code is a "410 Gone". This works exactly the same as the similar methods like isNotFound simply by checking the status code. This change takes the opinion that a 410 Gone should not be included in the isNotFound() method. Further discussion can be seen in the issue.
Contributor
|
@asgrim Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in zendframework/zendframework#7368 this change adds a new
method \Zend\Http\Response->isGone() to determine if the status code is
a "410 Gone". This works exactly the same as the similar methods like
isNotFound simply by checking the status code.
This change takes the opinion that a 410 Gone should not be included in
the isNotFound() method. Further discussion can be seen in the issue.
Originally from #3 but to merge against
developbranch this time.