This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Client\Adapter\Proxy, Socket, and Test optimization on write() method to avoid repetitive uri->getQuery() when possible #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samsonasik
commented
May 6, 2018
samsonasik
commented
- Is this related to quality assurance?
… to avoid repetitive uri->getQuery() when possible
| $path = $uri->getPath(); | ||
| if ($uri->getQuery()) { | ||
| $path .= '?' . $uri->getQuery(); | ||
| if ($query = $uri->getQuery()) { |
Member
There was a problem hiding this comment.
I really don't like doing assignment in conditionals, as it's an easy vector for mistakes. When I merge, I'll assign prior to the conditional.
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
Member
|
Thanks, @samsonasik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.