Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@prabathkela
Copy link
Contributor

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?
    it is a typographical and/or grammatical fix

@glensc
Copy link
Contributor

glensc commented Jul 31, 2019

commit message and PR title/body should describe the change, otherwise, it's good.

@prabathkela prabathkela reopened this Jul 31, 2019
@michalbundyra michalbundyra added this to the 2.10.1 milestone Oct 18, 2019
michalbundyra added a commit that referenced this pull request Oct 18, 2019
Update smtp-multiple-send.md
@michalbundyra
Copy link
Member

Thanks, @prabathkela!

@michalbundyra michalbundyra merged commit cc2cf2c into zendframework:master Oct 18, 2019
michalbundyra added a commit that referenced this pull request Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants