This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Removed lowercase console alias from default service config #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alias was added in the `ServiceListenerFactory` to add the lowercase aliases for `console` and `config`. This caused a `Zend\ServiceManager\Exception\InvalidServiceNameException` exception to be throw within the Zend\ServiceManager package when using the default configuration prior to v3.x. Within Zend\ServiceManager v3.x, the service manager has become case sensitive, meaning that this issue would be resolved. However, as v2.x normalises the aliases, it classifies `console` and `Console` as a duplicate key, and throws the aforementioned exception. This is a fix is only required as of v2.x of zend-mvc Added data provider tests for expected aliases for default config
mattroylloyd
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alias was added in the
ServiceListenerFactoryto add the lowercasealiases for
consoleandconfig. This caused aZend\ServiceManager\Exception\InvalidServiceNameExceptionexception tobe throw within the Zend\ServiceManager package when using the default
configuration prior to v3.x.
Within Zend\ServiceManager v3.x, the service manager has become case
sensitive, meaning that this issue would be resolved.
However, as v2.x normalises the aliases, it classifies
consoleandConsoleas a duplicate key, and throws the aforementioned exception.This is a fix is only required as of v2.x of zend-mvc
Added data provider tests for expected aliases for default config