This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Minor comment update #284
Closed
Minor comment update #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2018 10:49
Author
|
Also, I wonder about the existing comment that "the conditional will always pass". I think that's true. Then does it need to be a conditional? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying the language used in
injectEventManager's comments.The original statement that a shared event manager is injected into an existing event manager is incorrect - the code replaces the existing event manager with a new one.
I may have added too much 'how it works' detail, but I puzzled over this a bit so I thought the explanation might help future readers.