This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Fix invokable configuration when key is not provided and docs update #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $dependencies = [ | ||
| 'invokables' => [ | ||
| TestAsset\Service::class, |
Member
There was a problem hiding this comment.
Does this work in other containers at this time?
In zend-servicemanager currently, it doesn't; omitting the key means an alias is created, regardless of whether that alias is an integer. From what I can read of zend-auradi-config, it will not handle this, either.
The same behaviour we have in zend-servicemanager.
Proper configuration should be:
'invokables' => [
Name\Service::class => Name\Service::class,
],
or when we want to use alias:
'invokables' => [
'alias' => Name\Service::class,
],
then serivce will be available on:
- alias: $container->get('alias');
- class name: $container->get(Name\Service::class);
and it will be exactly the same instance.
geerteltink
reviewed
Feb 8, 2018
test/ConfigTest.php
Outdated
| } | ||
|
|
||
| public function testInvokablesWithoutAlias() | ||
| public function testInvokableWithAlias() |
Member
There was a problem hiding this comment.
Should be testInvokableWithoutAlias?
test/ConfigTest.php
Outdated
| self::assertTrue($this->container->offsetExists('0')); | ||
| } | ||
|
|
||
| public function testInvokableWithoutAlias() |
Member
There was a problem hiding this comment.
Should be testInvokableWithAlias?
Member
Author
|
I've create new repo with container common tests: https://github.com/webimpress/zend-container-test and added these test cases there. |
weierophinney
added a commit
that referenced
this pull request
Mar 15, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 15, 2018
Forward port #7 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed invokable configuration - if key is different than class name the key is used as an alias.