404s ActionController::notFound should not modify the route match

[zfbot]

Jira Information

Original Issue:	ZF2-223
Issue Type:	Bug
Reporter:	omerida
Created:	03/14/12
Assignee:	weierophinney
Components:	Zend\Mvc

Description

Raising a 404 in a controller by calling notFound causes the view layer to look for the wrong template.

It shouldn't modify the routematch. Per weirophinney:

"We need to alter this to not modify the route match; it's a bad practice
stemming from the hack we used for view rendering prior to introducing
the new view layer. "

[zfbot]

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF2-223

Known GitHub users mentioned in the original message or comment:
@omerida, @weierophinney

[SlashBin]

This also seems to impact the solution in #2604 for changing the layout on a 404 page. It does not appear to do emit a dispatch.error event.

[ralphschindler]

@weierophinney what are your thoughts here, I see you had some discussions in #2604

[weierophinney]

The code is still present; altering it at this point would be a BC break.

If users want alternate functionality to occur, it's easily accomplished by overriding the notFoundAction within their controller; as such, we don't need to solve it within the framework.

[ThaDafinser]

@weierophinney it's only partly correct...if the 404 is a "no route match" than your suggested method notFoundAction will be skipped...

see here #2604 (comment)

[weierophinney]

@ThaDafinser if we have no route match, no controller is executed anyways...

[ThaDafinser]

@weierophinney yes that's the problem....

In ZF1 you just had a ErrorController, there ALL 404/errors were catched and you could do whatever you wanted (logging, custom pages, ...).

Now you have to do this with events, otherwise you can just change the template for the 404/errors (and not all errors are catched there).

The main problem IMO is that it's more difficult than before:

Case 1) MvcEvent::EVENT_DISPATCH_ERROR
Catch thrown Exceptions

Case 2) MvcEvent::EVENT_DISPATCH (maybe could be done with low priority MvcEvent::EVENT_ROUTE)
Catch all 404 (included "no route match")

Case 3) MvcEvent::EVENT_RENDER_ERROR
Catch "view not found" and other related things...

BUT here are still things missing:

• Normal PHP erros (unknown functions, ...)
• view errors (undefined variable, ...)