Setup testing #13

stankoua · 2018-02-14T23:02:33Z

No description provided.

cchantep · 2018-02-15T01:02:27Z

core/src/test/scala/module/sql/models/Material.scala

+
+  def fetchMaterial(id: Int): SqlQuery[Option[Material]] = {
+    SqlQuery { implicit connection =>
+      SQL"SELECT * FROM materials where id = {id}"


cchantep · 2018-02-15T01:03:15Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+      } yield (professor, material)
+      val resF = runner(query)
+      val result = Await.result(resF, 1.minute)
+      result aka "professor and material" mustEqual None


cchantep · 2018-02-15T01:04:17Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+      val result = Await.result(resF, 1.minute)
+      result aka "professor and material" mustEqual Tuple2(
+        Professor(1, "John Doe", 35, 1),
+        Material(1, "Computer Science", 20, "Beginner"))


cchantep · 2018-02-15T08:41:09Z

build.sbt

    name := "query-core",
    libraryDependencies ++= Seq(
-      Dependencies.cats
+      Dependencies.acolyte,


cchantep · 2018-02-15T08:51:54Z

core/src/main/scala/core/database/package.scala

  type QueryO[Resource, A] = QueryT[Option, Resource, A]

-  type QueryE[Resource, A, Err] =
+  object QueryO {


Duplication par rapport à généricité sur QueryT

Je trouve un peu frustrant d'avoir un type dans l'api (pour améliorer la lisibilité) et de devoir faire appel au companion du type générique pour construire son instance.

Une proposition alternative que je pourrai faire c'est d'extraire les fonctions de QueryT et de les mettre dans un trait partagé par les companions objects QueryT, QueryO et QueryE. @cchantep qu'en penses-tu ?

pour moi ces objects ne sont que des convenient instances de QueryT, dupliquer toute la logique apply, pure, ask, liftF, fromQuery ne me semble pas approprié.

cchantep · 2018-02-15T08:52:30Z

core/src/main/scala/core/module/sql/package.scala

+
+  type SqlQueryO[A] = QueryO[Connection, A]
+
+  object SqlQueryO {


Duplication

cchantep · 2018-02-15T08:54:40Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+        SqlConnectionFactory.withSqlConnection(AcolyteQueryResult.Nil)
+      val runner = SqlQueryRunner(withSqlConnection)
+      val query = SqlQuery.pure(1)
+      val resF = runner(query)


runner(query) must beTypedEqualTo(1).await

cchantep · 2018-02-15T09:02:51Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+        _ <- SqlQuery.ask
+        professor <- Professor.fetchProfessor(2)
+      } yield professor
+      val resF = runner(query)


runner(query) must beNone.await

cchantep · 2018-02-15T09:07:48Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+
+    // execute composed queries into a single transaction
+    "retrieve professor with id 1 and his material" in {
+      val handler = AcolyteDSL.handleStatement


For a query only handler, AcolyteDSL.handleQuery { .. }

cchantep · 2018-02-15T09:08:41Z

core/src/test/scala/module/sql/models/Professor.scala

+
+  def fetchProfessor(id: Int): SqlQuery[Option[Professor]] = {
+    SqlQuery { implicit connection =>
+      SQL"SELECT * FROM professors where id = {id}"


cchantep · 2018-02-15T09:12:41Z

core/src/main/scala/core/database/QueryRunner.scala

+      implicit ec: ExecutionContext
+  ) extends QueryRunner[Resource] {
+
+    def apply[M[_], T](query: QueryT[M, Resource, T]): Future[M[T]] =


!!! Si M = Future

Effectivement. Mais je trouve ça commode de pouvoir run directement un QueryT sans avoir à repasser à une Query. Je pourrai essayer de restreindre en demandant une evidence en implicit mais j'ai plutôt envie de dire que c'est à l'utilisateur de gérer ça.

Sauf que le loan pattern ne gèrera pas correctement (ça échouera) la ressource si le traitement Query se base sur M=Future

cchantep · 2018-03-16T09:17:39Z

core/src/main/scala/core/database/ComposeWithCompletion.scala

+    type Outer = Future[F[A]]
+
+    def apply[In](resource: In, f: In => F[A])(onComplete: In => Unit)(implicit ec: ExecutionContext): Outer = {
+      Try {


/* ? */ Future(f(resource)).andThen { case _ => onComplete(resource) }

cchantep · 2018-03-16T09:20:14Z

core/src/test/scala/module/sql/SqlQueryRunnerSpec.scala

+        SqlConnectionFactory.withSqlConnection(AcolyteQueryResult.Nil)
+      val runner = SqlQueryRunner(withSqlConnection)
+      val query = SqlQuery.pure(1)
+      runner(query) aka "material" must beTypedEqualTo(1).await


J'aèrerais avec une ligne d'espace entre le bloc de déclaration/val et l'expectation

cchantep · 2018-03-16T09:22:28Z

examples/sample-app/app/wiring/AppLoader.scala

+          SqlQueryT{implicit c =>
+            Future {
+              Thread.sleep(2000) // Simumlates a a very slow query
+              val r = SQL"select sqrt($num) as result".as(SqlParser.double("result").single)


val r = ...; r => ... ?

cchantep · 2018-03-16T10:14:14Z

@stankoua Sur les tests, tu as un soucis de cohérence du formattage : https://travis-ci.org/zengularity/query-monad/builds/354037179#L504

cchantep · 2018-03-18T13:27:10Z

core/src/main/scala/core/database/ComposeWithCompletion.scala

 /**
- * Heavily inspired from work done by @cchantep in Acolyte (see acolyte.reactivemongo.ComposeWithCompletion)
- */
+  * Heavily inspired from work done by @cchantep in Acolyte (see acolyte.reactivemongo.ComposeWithCompletion)


Indent issue

Yes, I have an issue with scalafmt which doesn't format properly scaladoc. I'm working on an PR to update scalafmt settings.

stankoua added PR-status: need-review PR-type: Task labels Feb 14, 2018

stankoua self-assigned this Feb 14, 2018

stankoua requested a review from cchantep February 14, 2018 23:02

stankoua force-pushed the task/setup-testing branch from 96d4cd0 to 1ecfcad Compare February 14, 2018 23:44

cchantep requested changes Feb 15, 2018

View reviewed changes

stankoua force-pushed the task/setup-testing branch 3 times, most recently from 84912d9 to fee481c Compare February 20, 2018 00:34

stankoua added 4 commits February 21, 2018 17:22

WIP: add acolyte dependency

b9b847a

Add use case + specs for SqlQueryRunner

414dd1a

Formatting code + test

137dcdf

Refactor tests with specs2 matchers + update build.sbt

e02d1f2

stankoua force-pushed the task/setup-testing branch from fee481c to e02d1f2 Compare February 21, 2018 16:22

Add trait for companion objects functions

62b0edc

stankoua force-pushed the task/setup-testing branch from eaad42d to b956e67 Compare February 21, 2018 23:03

Add combinator for asynchronous effects

c350426

stankoua force-pushed the task/setup-testing branch from b956e67 to c350426 Compare February 21, 2018 23:06

stankoua added 2 commits February 23, 2018 06:45

Removing type alias companions

982b217

Add a ComposeWithCompletion to handle async structures

d334bbe

cchantep reviewed Mar 16, 2018

View reviewed changes

stankoua added 2 commits March 18, 2018 14:07

Refactor: cleaning

4b61d30

Formatting

640aa8b

cchantep reviewed Mar 18, 2018

View reviewed changes

cchantep approved these changes Apr 13, 2018

View reviewed changes

stankoua merged commit 2e20857 into master Apr 13, 2018

stankoua deleted the task/setup-testing branch April 13, 2018 15:19

stankoua mentioned this pull request Apr 26, 2018

Testing #4

Closed

stankoua removed the PR-status: need-review label Oct 1, 2019

Setup testing #13

Setup testing #13

Uh oh!

Conversation

stankoua commented Feb 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stankoua Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cchantep commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stankoua Feb 21, 2018 •

edited

Loading