Skip to content

Fix memory leak of messages received from safekeepers. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hlinnaka merged 1 commit into from
Feb 10, 2022
Merged

Fix memory leak of messages received from safekeepers. #129

hlinnaka merged 1 commit into from
Feb 10, 2022

Conversation

@hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Feb 9, 2022

@hlinnaka hlinnaka requested a review from arssher February 9, 2022 22:45
@arssher
Copy link

arssher commented Feb 10, 2022

ISTM it would be simpler to do free inside libpqprop_async_read, having the guarantee that the result lives until the next call, like libpqwalreceiver does, but ok.

@hlinnaka hlinnaka force-pushed the fix-safekeeper-response-leak branch from 6150756 to cce6877 Compare February 10, 2022 06:28
@hlinnaka
Copy link
Contributor Author

hlinnaka commented Feb 10, 2022

ISTM it would be simpler to do free inside libpqprop_async_read, having the guarantee that the result lives until the next call, like libpqwalreceiver does, but ok.

Makes sense, I rewrote it that way.

@hlinnaka hlinnaka requested a review from arssher February 10, 2022 06:29
@hlinnaka hlinnaka mentioned this pull request Feb 10, 2022
Merged
@hlinnaka hlinnaka force-pushed the fix-safekeeper-response-leak branch from cce6877 to e056fb6 Compare February 10, 2022 09:27
hlinnaka added a commit to neondatabase/neon that referenced this pull request Feb 10, 2022
@hlinnaka
Bump vendor/postgres, to fix memory leak.
c45ee13 
See neondatabase/postgres#129
@hlinnaka hlinnaka merged commit e056fb6 into main Feb 10, 2022
@hlinnaka hlinnaka deleted the fix-safekeeper-response-leak branch February 10, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arssher arssher arssher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PQgetCopyData result is never freed in walproposer

3 participants

@hlinnaka @arssher