-
Notifications
You must be signed in to change notification settings - Fork 71
Add ResearchRadar project #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You'll also need to update the main |
strickvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, just some small nits.
Also, you should be sure to run our formatting script on your code before merging (scripts/format.sh).
htahir1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V cool - wonder if we can give it a cool name ? Like DocumentClassifier
Ah yes I forgot to mention that too. I think there's still a little bit more to be done around the 'make it a project' thing.
We'd need a paragraph somewhere in the docs where we explain that this specific implementation focus on LLMOps etc, but that it's easily adapted to user needs. WDYT? |
|
@strickvl thanks a lot for reviewing this so quickly! I think "ResearchRadar" is super cool. The description is pretty great too 🤓 |
|
@strickvl @htahir1 The workflow is failing due to version incompatibility: runner uses ZenML 0.80.0 client |
|
We're gonna rethink the workflow anyway tbh so lets just ignore that for now |
strickvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits, but otherwise LGTM!
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
htahir1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! @marwan37 after this you'd need to add it to the projects-backend repo here https://github.com/zenml-io/zenml-projects-backend and on the website https://zenml.io/projects.. also https://docs.zenml.io/user-guides
No description provided.